Commit Graph
32590 Commits
Author SHA1 Message Date
Oliver Gondža c8ee877216 Towards 2.204.1 2019-11-21 19:55:30 +01:00
Josh Soref 76b08acd1c Rename checkPermission argument to trustAdmins 2019-11-21 11:33:13 -05:00
Daniel Beck b9bd513f48 Update bundled script-security to 1.68 2019-11-21 15:19:45 +01:00
Oleg Nenashev fd02997e95 Merge pull request #4364 from StefanSpieker/UTF_8
use StandardCharsets.UTF_8 instead of string
2019-11-21 13:53:22 +01:00
Kohsuke Kawaguchi 81479359c3 [maven-release-plugin] prepare for next development iteration 2019-11-20 12:35:52 -08:00
Kohsuke Kawaguchi e50a53f12b [maven-release-plugin] prepare release jenkins-2.190.3 jenkins-2.190.3 2019-11-20 12:35:42 -08:00
Mark Waite 360029e9d5 Merge pull request #4361 from StefanSpieker/try_with_resources
Try with resources instead of try finally
2019-11-18 05:28:57 -07:00
StefanSpieker 5057edae53 introduced junit5 as testing backend for cli tests (#4220) 2019-11-18 11:18:22 +01:00
Oleg Nenashev cce9587639 Merge pull request #4357 from bulanovk/JENKINS-60167
[JENKINS-60167] - Fix AtomicFileWriter performance issue on CephFS in case of Empty File creation
2019-11-18 11:09:02 +01:00
Oleg Nenashev 16041cb941 Merge pull request #4362 from fqueiruga/JENKINS-60189
[JENKINS-60189] - Open plugin and license links on a separate tab
2019-11-18 11:07:51 +01:00
Kohsuke Kawaguchi a1e740a56d [maven-release-plugin] prepare for next development iteration 2019-11-17 16:38:56 -08:00
Kohsuke Kawaguchi 7e5259b024 [maven-release-plugin] prepare release jenkins-2.205 jenkins-2.205 2019-11-17 16:38:40 -08:00
Stefan Spieker 6acb0913c9 use StandardCharsets.UTF_8 instead of string 2019-11-17 17:39:03 +01:00
Oleg Nenashev 152618a4de Merge pull request #4359 from Wadeck/JENKINS-60180_http_trace
[JENKINS-60180] Disable HTTP TRACE
2019-11-16 10:41:06 +01:00
Daniel Beck 77f1242ddd Move cloud configuration out of Configure System (#4339)
* Move cloud configuration out of Configure System

* Update display name

* Add section header back
2019-11-16 10:37:27 +01:00
Félix Queiruga aa4f1eefa8 Open plugin and license links on a separate tab 2019-11-15 19:51:16 +01:00
Stefan Spieker 7f8c04641f reverted some whitespace changes 2019-11-15 18:12:43 +01:00
Stefan Spieker 5c027dfc94 removed dangling comments 2019-11-15 18:02:26 +01:00
Stefan Spieker 4cad1a455f use try with resources instead of try finally 2019-11-15 17:49:05 +01:00
Stefan Spieker ccdb6350f7 use try with resources instead of try finally 2019-11-15 17:39:11 +01:00
Grace TangandOleg Nenashev 8a2f761431 Reduce log levels for successful run completion and update center polling events (#4345)
* Rejuvenate log levels

* clean up

* Reverting the plugin download

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
2019-11-15 15:12:29 +01:00
Wadeck Follonier b8cf149569 [JENKINS-60180] Disable HTTP TRACE 2019-11-15 10:45:07 +01:00
Mark Waite fd932fef98 Merge pull request #4354 from uhafner/doc-repeatableProperty
Document workaround for Stapler data binding bug in repeatableProperty
2019-11-14 06:09:02 -07:00
f103b7819d JENKINS-56553 Make proxy config compatible with JCasC without workarounds on the plugin side (#3935)
* JENKINS-56553 Make proxy config compatible with JCASC

* Use DataBoundSetters as other fields are optional

* Fix Jelly for ProxyConfiguration

* Use default field name now that field matches

* Fix validate proxy

* Change field type

* After review

* Update core/src/main/java/jenkins/model/Jenkins.java

Co-Authored-By: timja <t.jacomb@kainos.com>

* Update core/src/main/java/jenkins/model/Jenkins.java

Co-Authored-By: timja <t.jacomb@kainos.com>

* Update core/src/main/java/hudson/ProxyConfiguration.java

Co-Authored-By: timja <t.jacomb@kainos.com>

* Update core/src/main/java/jenkins/model/Jenkins.java

Co-Authored-By: timja <t.jacomb@kainos.com>

* Update core/src/main/java/jenkins/model/Jenkins.java

Co-Authored-By: timja <t.jacomb@kainos.com>

* Update core/src/main/java/hudson/ProxyConfiguration.java

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* Tweak javadoc

* Align fields

* Update core/src/main/java/hudson/ProxyConfiguration.java

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
2019-11-14 13:40:53 +01:00
austry b6779ac9c9 JENKINS-6722 Show agent error status on the dashboard (#4322)
* JENKINS-6722 Show slave error status on Dashboard

* Update executors.properties
2019-11-14 13:39:27 +01:00
Konstantin Bulanov 7694555886 Fix JENKINS-60167
Add StandardOpenOption.CREATE flag to create FileChannelWriter to avoid full fs flush and 5sec log operation on creating empty file with CephFS as a storage
2019-11-14 13:49:00 +04:00
Jesse Glick 376b14f099 Merge pull request #4351 from jglick/jetty-maven-plugin
Switch from maven-jenkins-dev-plugin to upstream jetty-maven-plugin
2019-11-13 08:45:53 -05:00
Jesse Glick bfa16ee1ee Use -pl instead of -f for submodule selection (suggestion from @albers). 2019-11-13 08:42:38 -05:00
Baptiste Mathus a8853c26e2 Merge pull request #4349 from fqueiruga/JENKINS-59508
[JENKINS-59508] Sidebar links show full label on hover
2019-11-13 14:22:01 +01:00
Ulli Hafner c6905b506d Document workaround for Stapler data binding bug. 2019-11-13 10:27:35 +01:00
Daniel Beckanddaniel-beck 90e693b13b Hide password form fields by default (#3991)
* Hide password form fields by default

* Trying to bypass enforced autocompletion by just having a test field at first

Something like onfocus didn't work, you'd tab through form elements
and unless you filled in the user name, changing the form field to
password would cause it to autocomplete.

It looks like, at least in Mac/Firefox, going from plain text to password
in the 'oninput' event handler works. The plain text is revealed neither
with typing nor pasting.

* Update core/src/main/resources/lib/form/password.jelly

Co-Authored-By: daniel-beck <daniel-beck@users.noreply.github.com>

* Use previously defined value

* Make new password form fields opt-out

* Add support for redacting form secrets in new password field

* Have a password value pre-set in Jelly

* Fix method

* Fix test by clicking on the button to change the password

* Forgot period separator between class and property name
2019-11-13 10:22:40 +01:00
Manuel 5f413e5c41 [JENKINS-59665] - Fix sorting of the Uninstall column in the Install pane of the Plugin Manager (#4298)
* refs #JENKINS-59665 Fixed sorting for uninstall column of installed in plugin manager

* refs #JENKINS-59665 removed test attribute
2019-11-13 10:17:01 +01:00
Tommy Sparber 12e3345dae Remove unused jenkins-slave.xml file from core (#4330)
The jenkins-slave.xml file has been copied to the windows-slave-installer-module,
but a unused (old) copy is still present in the jenkins core.
2019-11-13 10:15:56 +01:00
Baptiste Mathus 5f810770b4 Merge pull request #4346 from MRamonLeon/JENKINS-59793
[JENKINS-59793] Avoid hanging jobs with faulty SubTasks
2019-11-13 09:52:49 +01:00
Jesse Glick f76df749b5 Adjusting first-time launch instructions. 2019-11-12 11:29:21 -05:00
Jesse Glick 7d97c1f574 Noting problem with maven-plugin builds. 2019-11-12 10:03:04 -05:00
Jesse Glick 035ca2be1c Some references in Javadoc to hudson-dev:run. 2019-11-12 09:33:13 -05:00
Jesse Glick 9526bfd408 Fixing contributing instructions. 2019-11-12 09:25:43 -05:00
Daniel Beck 7e4ebd562a Try to execute flyweight tasks on the master (#3983)
* Try to execute flyweight tasks on the master

* Fix offline behavior, add tests

* Remove obsolete TODOs, also check #isAcceptingTasks
2019-11-12 15:18:42 +01:00
Jesse Glick bd0d3b5cf8 Stray reference to maven-jenkins-dev-plugin. 2019-11-12 09:18:35 -05:00
Jesse Glick d188ab7855 Merge branch 'master' into jetty-maven-plugin 2019-11-12 09:14:21 -05:00
Oleg Nenashev db7f7b42f6 Merge pull request #4342 from kdanW/JENKINS-59631
[JENKINS-59631] Fix styling issue in build history table
2019-11-12 15:06:19 +01:00
Oleg Nenashev 196d9883c9 Merge pull request #4350 from jglick/cli-remoting-dep
jenkins-cli.jar no longer needs to bundle remoting
2019-11-12 15:05:16 +01:00
Oleg Nenashev 543b5c1a03 Merge pull request #4347 from olamy/winstone_5_4
[JENKINS-60098] - Upgrade to winstone 5.4 to take advantage of Jetty 9.4.22
2019-11-12 15:04:14 +01:00
M Ramon Leon 5fb44bd890 [FNDJEN-59793] Rollback to original fix plus NoExternalUse 2019-11-12 12:44:53 +01:00
Pierre-Louis Bonicoli 4956998996 getPrimaryView: return null if no view is defined
This exception occurs while defining a view using job DSL:

    SEVERE  jenkins.InitReactorRunner$1#onTaskFailed: Failed ConfigurationAsCode.init
    java.lang.ArrayIndexOutOfBoundsException: 0
        at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:388)
        at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:397)
        at hudson.model.ViewGroupMixIn.getPrimaryView(ViewGroupMixIn.java:172)
        at hudson.model.ViewGroupMixIn.getView(ViewGroupMixIn.java:134)
        at jenkins.model.Jenkins.getView(Jenkins.java:1834)
        at javaposse.jobdsl.plugin.JenkinsJobManagement.createOrUpdateView(JenkinsJobManagement.java:175)
        at javaposse.jobdsl.dsl.JobManagement$createOrUpdateView$2.call(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:141)
        at javaposse.jobdsl.dsl.AbstractDslScriptLoader$_extractGeneratedViews_closure5.doCall(AbstractDslScriptLoader.groovy:216)
2019-11-12 09:28:20 +01:00
M Ramon Leon cff85468bb [FNDJEN-59793] Ensure the new exceptions thrown set the future as well 2019-11-11 17:50:44 +01:00
M Ramon LeonandStephen Connolly d96ac8139f [FNDJEN-59793] Change test name and avoid extra assertions
Co-authored-by: Stephen Connolly <stephen.alan.connolly@gmail.com>
2019-11-11 12:49:50 +01:00
Josh SorefandDaniel Beck 4cd3e338c0 IntelliJ/Java: Duplicate code -- Refactored as DOSToUnixPathHelper.validate (#4080)
* IntelliJ/Java: Duplicate code -- Refactored as DOSToUnixPathHelper.validate

* Change DOSToUnixPathHelper from validate() to iteratePath()

* Refactor DOSToUnixPathHelper checkPrefix

* mark DOSToUnixPathHelper as NoExternalUse

* Do not tempt fate

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2019-11-11 12:19:16 +01:00
Kohsuke Kawaguchi facdfd73c9 [maven-release-plugin] prepare for next development iteration 2019-11-10 16:51:10 -08:00