Commit Graph
32590 Commits
Author SHA1 Message Date
Stefan Spieker 9df94bdf16 added CheckForNull 2019-10-25 18:15:26 +02:00
Oleg Nenashev 9225492a0a Revert "Revert "Disable Windows builds and ATH to mitigate the ongoing INFRA issue" (#4155)" (#4316)
This reverts commit e37cd74f04.
2019-10-25 13:15:01 +03:00
Daniel Beck e084ac66bd Merge pull request #3894 from daniel-beck/auto-refresh-telemetry
Add telemetry for 'auto refresh' feature
2019-10-24 23:46:16 +02:00
Basil Crow 2644e38e84 Move since Javadoc to after return Javadoc 2019-10-24 09:17:28 -07:00
Jesse Glick af40d366e7 Merge pull request #4313 from jglick/milestone
[JENKINS-58625] Cancel older builds of a given branch
2019-10-24 08:12:42 -04:00
Markus Winter eebe7307b6 [JENKINS-59904] very there are cookies
avoid NullPpointerException when there are no cookies in the request.
2019-10-24 08:29:35 +02:00
Jesse Glick 3b3a2f5760 [JENKINS-58625] Cancel older builds of a given branch. 2019-10-23 16:54:04 -04:00
Roberto C. Salome b86141c84a JENKINS-17459: Clicking red/yellow/green icons link to the build Console
Clicking on the build status icon in a job's "Build Time Trend" will now
take you to that build's console. This is the same behavior a user
expects when clicking on the build status icon in a job's "Build
History" widget.
2019-10-23 14:03:41 -04:00
Oleg Nenashev e37cd74f04 Revert "Disable Windows builds and ATH to mitigate the ongoing INFRA issue" (#4155)
* Revert "Disable Windows builds, ATH and Incrementals to mitigate the ongoing INFRA issue (#4153)"

This reverts commit 3356311377.

* Jenkinsfile: Prepare to Windows Docker agents

* Revert the Linux label patch for the ATH step

* Disable Benchmarks for Windows
2019-10-23 19:37:01 +03:00
Thomas de Grenier de Latour 79b624f2c1 [JENKINS-58296] Revert "[JENKINS-53462] Submit form on Firefox as well" (#4246)
* [JENKINS-58296] Revert "[JENKINS-53462] Submit form on Firefox as well"

This reverts commit acc4eec688.
This change had been made in Jenkins to anticipate Firefox not dispatching
untrusted submit events anymore in v69, but this has actually been backed out.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1370630

Since this change seems to have introduced a double-submission bug on forms
with inputs of type "file", reverting sounds like the next logical step.

* [JENKINS-58296] added comment about the Firefox case
2019-10-23 19:29:06 +03:00
Oleg Nenashev 619c2e3bc1 Merge pull request #4303 from daniel-beck/log-jenkins-home
Use actual logger to record Jenkins home and where it was found
2019-10-23 19:25:50 +03:00
anafke 8b2da7dcd6 Add java.util.concurrent.ConcurrentLinkedDeque to the class deserialization whitelist (JEP-200) (#4300)
* Add java.util.concurrent.ConcurrentLinkedDeque

Recently upgraded and one of our in-house plugins failed due to:

Caused by: java.lang.UnsupportedOperationException: Refusing to marshal java.util.concurrent.ConcurrentLinkedDeque

Since both java.util.ArrayDeque and java.util.concurrent.ConcurrentLinkedQueue are whitelisted, it makes sense to also whitelist this class.

* Update whitelisted-classes.txt
2019-10-23 19:25:23 +03:00
Raihaan Shouhell 06f4c89121 Replace ACL.impersonate with ACL.as (#4253)
* Replace ACL.impersonate with ACL.as

* Fix based on suggestions

* 🤦 accidentally removed a line
2019-10-23 00:57:49 +03:00
Josh SorefandOleg Nenashev cc83bf0ee0 Introduce new Run#getBuildsOverThreshold() method for getting runs above the desired execution result (#4259)
* IntelliJ/Java: Duplicate code

Refactored as Run.getBuildsOverThreshold

* CheckForNull

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* getBuildsOverThreshold: get RunT using _this()
2019-10-23 00:56:39 +03:00
Daniel Beck 987ca9855f Merge pull request #4292 from daniel-beck/update-at-since-2019-10
Update at-since in Javadoc, make script work on Mac OS X
2019-10-22 12:03:28 +02:00
Basil Crow 445eff4ada Rewrite Item#getRelativeNameFrom Javadoc 2019-10-21 09:12:10 -07:00
Oliver Gondža b98c6f456a Bump ATH to fixed version 2019-10-21 10:45:52 +02:00
Daniel Beck 7bc18eeba5 Use actual logger to record Jenkins home and where it was found 2019-10-21 10:22:39 +02:00
Kohsuke Kawaguchi 34d2e743bd [maven-release-plugin] prepare for next development iteration 2019-10-20 16:47:23 -07:00
Kohsuke Kawaguchi 0f94f12ecc [maven-release-plugin] prepare release jenkins-2.201 jenkins-2.201 2019-10-20 16:47:11 -07:00
Basil Crow 36d445ee3f Use links where applicable 2019-10-19 14:38:10 -07:00
Basil Crow a090ad991c Remove unnecessary {@inheritDoc} Javadoc comments 2019-10-19 14:16:09 -07:00
Basil Crow 861855953b Replace <code>…</code> with {@code …} 2019-10-19 14:02:59 -07:00
Basil Crow 63441802d8 Fix unresolvable references in Javadocs 2019-10-19 14:02:59 -07:00
Basil Crow 20786f087b Fix dangling Javadocs 2019-10-19 14:02:59 -07:00
Basil Crow d88ad04fe8 Add missing @Deprecated annotations 2019-10-19 14:02:59 -07:00
Basil Crow a6e22982d4 Fix typos in Javadoc declarations 2019-10-19 14:02:59 -07:00
Daniel Beck 3de4d8faa2 Merge pull request #4302 from daniel-beck/JENKINS-59849
[JENKINS-59849] Don't fail to serve resource files with nontrivial names
2019-10-19 15:25:17 +02:00
Daniel Beck a2477f6448 Extend test to cover more complex dir structure 2019-10-18 22:11:26 +02:00
Daniel Beck fa4ec0a0e3 [JENKINS-59849] 2019-10-18 21:19:51 +02:00
Oleg Nenashev 11c1146d0d Merge pull request #4290 from darxriggs/resolve-todo-isExtensionsAvailable
Resolve RunListener TODO using Functions#isExtensionsAvailable
2019-10-18 11:47:17 +02:00
Oleg Nenashev 46ad013c34 Merge pull request #4296 from jenkinsci/contributing-java-versions
Contributing guidelines: Update the Java versions documentation
2019-10-18 11:39:32 +02:00
Oleg Nenashev ee56c4b901 Merge pull request #4295 from andipabst/fix-create-admin-headline-multiline
[JENKINS-59800] - Add line-height CSS property to fix the "Create Administrator Account" view headlines
2019-10-18 11:38:12 +02:00
StefanSpiekerandEvaristo Gutiérrez 89ee2e822a [JENKINS-36720] - Fix SpotBugs warnings for "Non-null field is not initialized" values (#4249)
* add one Spotbugs exclude and replaced Nonnull with CheckForNull because assigned variables have CheckForNull annotations

* Update core/src/main/java/jenkins/security/NonSerializableSecurityContext.java

Co-Authored-By: Evaristo Gutiérrez <egutierrez@cloudbees.com>
2019-10-18 00:30:31 +02:00
Oleg Nenashev ff3f95d4e9 Merge pull request #4287 from darxriggs/modernize-LoginRedirectTest
Modernize LoginRedirectTest
2019-10-17 11:49:29 +02:00
Oleg Nenashev 6580626222 Merge pull request #4289 from ventojna/spotbugs
[JENKINS-36720] - Spotbugs fix CO_COMPARETO_INCORRECT_FLOATING
2019-10-17 11:49:02 +02:00
Oleg Nenashev 20986fa481 Merge pull request #4293 from StefanSpieker/simplified
simplified assertions and removed unthrown exceptions
2019-10-17 11:48:03 +02:00
Oleg Nenashev a60bdca3d0 Merge pull request #4291 from damianszczepanik/translations-pl
Add Polish translations
2019-10-17 11:46:35 +02:00
Oleg Nenashev 15a34a4583 Merge pull request #4297 from jenkinsci/contributing_skipSpotbugs
Contributing guidelines: Skip SpotBugs instead of Findbugs for quick build
2019-10-17 11:45:13 +02:00
Oleg NenashevandDaniel Beck e7dcde8716 Update CONTRIBUTING.md
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2019-10-16 16:53:29 +02:00
Oleg Nenashev 0a1e26c9a0 Contributing guidelines: Skip SpotBugs instead of Findbugs 2019-10-16 15:56:30 +02:00
Oleg Nenashev 7e0c2b7b8c Merge pull request #4288 from darxriggs/resolve-todo-waitOnline
Resolve TODO using JenkinsRule#waitOnline
2019-10-16 13:30:20 +02:00
Oleg Nenashev 6f0cc87ebb Contributing guidelines: Update the Java versions documentation 2019-10-16 12:37:11 +02:00
Daniel Beck 67a9e8af38 Remove the backup file immediately 2019-10-16 12:23:01 +02:00
Daniel Beck 4d6590e768 Shellcheck findings 2019-10-16 12:22:47 +02:00
Daniel Beck d6c58cfdb6 Add changes from 2.200 2019-10-16 12:22:25 +02:00
Daniel Beck fdb6faed00 Update at-since in Javadoc, make script work on Mac OS X 2019-10-16 12:22:03 +02:00
andi 8aa6bc48b7 add line-height css property 2019-10-16 12:09:34 +02:00
Daniel Beck a231b74e2d Address review feedback 2019-10-15 19:56:12 +02:00
Kohsuke Kawaguchi 5b3ea20b68 [maven-release-plugin] prepare for next development iteration 2019-10-14 15:02:40 -07:00