Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 29e6ea7ada [maven-release-plugin] prepare release jenkins-2.200 jenkins-2.200 2019-10-14 15:02:30 -07:00
Oliver Gondža e4d54e5ca1 Update ATH version 2019-10-14 12:33:38 +02:00
StefanSpiekerandDaniel Beck 5e275dbc31 Apply suggestions from code review
Replaced instance calls with static calls as suggested by daniel-beck.

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2019-10-13 20:51:42 +02:00
Stefan Spieker 02fa8003c0 simplified assertions and removed unthrown exceptions 2019-10-13 20:42:29 +02:00
Damian Szczepanik 166f11ee8a Add Polish translations 2019-10-13 14:26:12 +02:00
Daniel Beck 50d15406f8 Apply code review suggestion, clean up imports 2019-10-13 01:44:24 +02:00
Daniel Beck 14b9462d00 Increase logging level to be visible 2019-10-13 01:41:16 +02:00
Daniel Beck a7cccf9d00 Simpler code 2019-10-13 01:39:21 +02:00
Daniel Beck f8df1cd432 Address review feedback 2019-10-13 01:11:29 +02:00
Daniel Beck 2b618f36c2 Add telemetry for 'auto refresh' feature 2019-10-13 01:11:29 +02:00
René Scheibe acb12ff17d Resolve RunListener TODO using Functions#isExtensionsAvailable
The mentioned ticket JENKINS-33377 has been resolved.
Therefore `isExtensionsAvailable` now also checks that Jenkins is not terminating.
2019-10-12 20:01:17 +02:00
René Scheibe 7a106b5366 Modernize LoginRedirectTest
Replace deprecated `HudsonTestCase` and add URL path assertions.
2019-10-12 19:58:25 +02:00
Jonas f951cc0b82 Removed empty line 2019-10-12 18:12:02 +02:00
Jonas f7f6d6d43f [JENKINS-36720] Fix Spotbug CO_COMPARETO_INCORRECT_FLOATING 2019-10-12 18:09:28 +02:00
René Scheibe 704fbcf5ff Resolve TODO using JenkinsRule#waitOnline 2019-10-12 16:27:07 +02:00
Joseph PetersenandTim Jacomb 34e1e14c0e spelling
Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>
2019-10-12 11:15:14 +02:00
Joseph Petersen c1b532b437 add since todo 2019-10-12 11:14:04 +02:00
Joseph Petersen aa863548bc Add Restricted no external use 2019-10-12 11:13:52 +02:00
Oleg Nenashev ab46f02bb4 Merge pull request #4276 from Wadeck/JENKINS-59684_monitor_info
[JENKINS-59684] Support "alert-info" for admin monitor in popup
2019-10-12 08:21:17 +02:00
Oleg Nenashev ef85b89323 Merge pull request #4285 from olivergondza/unify-js-validation
[JENKINS-59605] Unify the JS validation behavior and the AJAX one
2019-10-12 08:20:40 +02:00
Oleg Nenashev 368d1de36f Merge pull request #4256 from jsoref/java-cleanup-ChunkedInputStream.advanceChunk
IntelliJ/Java: Duplicate code -> ChunkedInputStream.advanceChunk
2019-10-12 08:20:16 +02:00
Oleg Nenashev 972249df6a Merge pull request #4269 from ilpianista/JENKINS-48375
[JENKINS-48375] - Make Atom the default feed type in UI and the response application type (Former RSS feeds use Atom)
2019-10-12 08:19:38 +02:00
19bcf575df Replaced static test classes with mocks (#4267)
* replaced static test classes with mocks

* added CALLS_REAL_METHODS as defaultAnswer

* Update core/src/test/java/hudson/slaves/NodeListTest.java

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Update core/src/test/java/hudson/slaves/NodeListTest.java

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
2019-10-12 08:18:54 +02:00
Oleg Nenashev 63cc1108f2 Merge pull request #4279 from 97gushan/master
[JENKINS-34226] No "pressed" style for OK button on Create Item
2019-10-12 08:17:32 +02:00
Oliver Gondža 270d967527 [JENKINS-59605] Unify the JS validation behavior 2019-10-11 13:36:44 +02:00
24d0cf90ab [JENKINS-41891] Resource domain support (#4239)
* [JENKINS-41891] Resorce domain support

* Rename a few things

* Encapsulate token

* Update documentation based on review feedback

* Rename field and change symbol for friendlier JCasC format

* Be more explicit about expiration and URL sharing

* Allow favicon.ico, robots.txt; better logging

* Remove TODO from comment

* Consider resource root URL only set if the Jenkins root URL is set

* Improve form validation

* Clean up form validation warnings a bit

* Fix null handling (even though it'll never be called that way)

* Simpler logging statement after code review

* It's nicer to read this way

* Use the proper API for this with less string magic

* Update TODO comments

* Simplify log statement

* Use base64 instead of hexadecimal for shorter URLs

* Open link to Wikipedia in new tab/window

* Serve directory indexes

* Fix target of redirect in admin monitor

* Update TODO comments in test to current implementation

* Include link to parent directory unless in top level directory

* Update validation message when we cannot determine instance identity

* Improve tests

* Fix permission exception, further improve tests

* Annotation was redundant

* Add test for resource domain monitor activation

* Do not go through hex encoding/decoding

* Address review comments

Co-Authored-By: Jesse Glick <jglick@cloudbees.com>

* Address further review feedback

* Better logging, handle exception when the user is gone

* Only get the bytes once

* Inline help improvements

Co-Authored-By: Jeff Thompson <jeffret.g@gmail.com>
2019-10-11 09:41:32 +02:00
Thomas de Grenier de Latour 96cc9ce0c5 added Functions.urlEncode(String) (#4278) 2019-10-11 09:31:40 +02:00
Oleg Nenashev 2f4210ab90 Split developer and internal changes (#4283) 2019-10-11 09:29:44 +02:00
Daniel Beck 070b625f0d Remove browser-based metadata download (#3970)
* Remove browser-based metadata download

* Fix Javadoc, add TODO

* Further cleanup

* Remove leftover reference to DownloadService from UI

* License header and note of origin for DailyCheck

* Add Javadoc with note about the update frequency
2019-10-11 08:25:29 +02:00
StefanSpieker b26fff4f37 Mark TarOutputStream as restricted (#4272)
* removed deprecated TarOutputStream

* restored TarOutputStream and added @Restricted(NoExternalUse.class) to the class as suggested

* Added @Restricted(NoExternalUse.class) to TarInputStream

* added the @RestrictedSince(2.200) as suggested
2019-10-10 17:03:51 +02:00
edh-oss adcf572f30 Update CONTRIBUTING.md (#4277)
The build no longer works with Maven 3.5.3.  If you try it, you end up with this:

[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (display-info) @ jenkins-parent ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
3.5.4+ required to use Incrementals.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Jenkins main module 2.199-SNAPSHOT ................. FAILURE [ 44.098 s]
2019-10-09 19:27:26 +02:00
97gushan 0f0c9934de [JENKINS-32226] No "pressed" style for OK button on Create Item 2019-10-09 12:08:56 +02:00
StefanSpieker 3c125400be [JENKINS-36720] - Fix SpotBugs warnings for "known as null" values (#4248)
* fixed spotbugs known as null values

* replaced annotation and created more useful log messages
2019-10-09 01:58:11 +02:00
Stefan Spieker 35dedaf917 merged master and use suggested type for tests 2019-10-08 23:35:34 +02:00
Oleg Nenashev 6adccd7dda Merge pull request #4258 from jsoref/java-cleanup-Computer.resolveForCLI
IntelliJ/Java: Duplicate code -> Computer.resolveForCLI
2019-10-08 16:47:11 +02:00
Daniel Beck 9afdb21d64 [JENKINS-59267] Increase ping frequency to prevent timeouts
(cherry picked from commit 84b07be2b7)
2019-10-08 14:37:52 +02:00
Marat Radchenko e2658e9660 [JENKINS-59580] Fix WindowsOSProcess.getEnvironmentVariables returning null
OSProcess.getEnvironmentVariables javadoc clearly states that method will return empty map if obtaining of environment variables failed.

(cherry picked from commit bc52cae16a)
2019-10-08 14:34:39 +02:00
Oleg Nenashev bd83468395 Merge pull request #4260 from jsoref/java-cleanup-View.makeSearchIndex
IntelliJ/Java: Duplicate code -> View.makeSearchIndex
2019-10-08 08:37:15 +02:00
Oleg Nenashev 04699a4db0 Merge pull request #4257 from jsoref/java-cleanup-PluginManager.logPluginWarnings
IntelliJ/Java: Duplicate code -> PluginManager.logPluginWarnings
2019-10-07 21:50:07 +02:00
Wadeck Follonier a03afb508c [JENKINS-59684] Also for alert-danger (security warnings) 2019-10-07 12:16:40 +02:00
Wadeck Follonier b274e4bebc [JENKINS-59684] Add support for alert-info also in the popup for admin monitor 2019-10-07 11:52:39 +02:00
Oleg Nenashev d5fe133097 Merge pull request #4261 from jsoref/java-cleanup-SettingsPath.getSettings
IntelliJ/Java: Duplicate code -> SettingsPath.getSettings
2019-10-07 10:23:59 +02:00
Kohsuke Kawaguchi 8e131f78f0 [maven-release-plugin] prepare for next development iteration 2019-10-06 16:55:07 -07:00
Kohsuke Kawaguchi eacdec3563 [maven-release-plugin] prepare release jenkins-2.199 jenkins-2.199 2019-10-06 16:54:57 -07:00
Oleg Nenashev 188ca140ee Merge pull request #4266 from jsoref/javadoc-hudson-Initializer-after
fix javadoc punctuation for Initializer.after
2019-10-06 12:26:10 +02:00
Oleg Nenashev abf4695421 Merge pull request #4263 from daniel-beck/JENKINS-59267
[JENKINS-59267] Increase ping frequency to prevent timeouts, and make it configurable
2019-10-06 11:31:31 +02:00
Andrea Scarpino 488dbe9f25 JENKINS-48375: Make Atom default and fix links' types 2019-10-06 10:31:10 +02:00
Oleg Nenashev 65c300dd65 Merge pull request #4268 from darxriggs/license-url
Use more common MIT license URL
2019-10-05 14:33:21 +02:00
René Scheibe f147d990ae Use more common MIT license URL 2019-10-05 09:22:47 +02:00
Oleg Nenashev 09c7a4b9ce Merge pull request #4251 from StefanSpieker/test_improvements
minor improvements to unit tests
2019-10-05 09:18:25 +02:00