Commit Graph
10778 Commits
Author SHA1 Message Date
Jesse Glick 53d1e20f62 If an optional component cannot be loaded, print a polite one-line message, not a big scary stack trace.
(To reproduce: BuildNowTextPropertyTest from cloudbees-template warns about FolderProxyGroupContainer.)
2013-05-02 14:55:06 -04:00
Donny Nadolny d658f55c30 Add extension point to rewrite JUnit test names
This adds an extension point, TestNameTransformer, which is called to transform JUnit test case names.
This is useful for JVM languages like scala which are more flexible than java with identifier naming.
Scala, for example, allows you to write test names between back ticks, and then encodes the name using valid java identifiers.
This extension point would allow a plugin to transform those names back in to readable names when they are displayed on the test result page.
2013-05-02 14:03:03 -04:00
Jesse Glick 21bf5c45d4 Diagnosis for test failure.
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/850/testReport/jenkins.security/RekeySecretAdminMonitorTest/testBasicWorkflow/
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 400 Bad Request for http://localhost:60027//administrativeMonitor/jenkins.security.RekeySecretAdminMonitor/scan
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:549)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:333)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:357)
	at com.gargoylesoftware.htmlunit.html.HtmlForm.submit(HtmlForm.java:196)
	at org.jvnet.hudson.test.HudsonTestCase.submit(HudsonTestCase.java:1178)
	at jenkins.security.RekeySecretAdminMonitorTest.testBasicWorkflow(RekeySecretAdminMonitorTest.java:112)
java.lang.Exception: Invalid request submission
	at org.kohsuke.stapler.HttpResponses.error(HttpResponses.java:79)
	at jenkins.security.RekeySecretAdminMonitor.doScan(RekeySecretAdminMonitor.java:117)
2013-05-02 08:55:31 -04:00
Kohsuke Kawaguchi 31eeb753aa merged back the RC branch 2013-05-01 20:37:34 -07:00
Jesse Glick 3c2b50ecfe [FIXED JENKINS-17681] Do not try to call resolveSymlink on a nonexistent link as you will just get an IOException, breaking peephole permalinks in some Windows environments. 2013-05-01 20:13:18 -04:00
Jesse Glick 00d5e38759 [JENKINS-17681] Set up a test which passes on Unix but fails on Windows when symlinks are enabled on the platform but disabled for the current user. 2013-05-01 19:10:30 -04:00
Jesse Glick 1e51b62298 [SECURITY-63] Check RUN_SCRIPTS for /eval.(cherry picked from commit 3d03990abc) 2013-05-01 14:16:49 -07:00
Jesse Glick 04403edc58 [SECURITY-63] Require POST for running Groovy scripts.(cherry picked from commit 3bbb65df3a) 2013-05-01 14:16:40 -07:00
Jesse Glick d482fc50fb [FIXED SECURITY-67] Forbid CSS links in markup to be on the safe side.(cherry picked from commit 1e19eb3ece) 2013-05-01 14:16:37 -07:00
Jesse Glick 6eb958a111 [JENKINS-3107] Icon looks better before button rather than after, for reasons of alignment with the rest of the form. 2013-05-01 16:58:09 -04:00
Jesse Glick d2eb9b4f63 [JENKINS-3107] IE 9 fix. 2013-05-01 16:54:08 -04:00
Jesse Glick ef3d6e46b9 [JENKINS-3107] Rather than preëxpanding the Advanced area, just show an icon. 2013-05-01 16:43:18 -04:00
Jesse Glick 7ce4807087 [JENKINS-3107] Expand an Advanced section if some fields are already customized.
Initial implementation handles only text fields, not e.g. checkboxes.
2013-05-01 14:10:09 -04:00
Oliver Gondža 2c240bdc87 [FIXED JENKINS-17030] Enable word breaking for job names 2013-05-01 18:32:13 +02:00
Jesse Glick d391bbee07 Debugging toString. 2013-04-30 17:09:28 -04:00
Jesse Glick 7f3096c558 Deferring formatting Logger messages unless and until the log formatter is run.
No need to call isLoggable if you are only calling simply getters and relying on toString later.
2013-04-30 16:53:27 -04:00
Jesse Glick fd31a5d85c [FIXED JENKINS-15309] Be robust against serialized ListView with jobNames==null. 2013-04-30 16:00:00 -04:00
imod b8adcb43dd add global maven config to define default settings providers 2013-04-30 20:38:35 +02:00
ssogabe 3f0f25fc6b forgot to replace XXX with 1.515 2013-04-30 22:09:50 +09:00
ssogabe 55a68acca9 [FIXED JENKINS-17715] Display Name is not shown 2013-04-30 20:49:58 +09:00
Vincent Latombe 1dc289e2ee Prevent ClassCastException when encountering ItemGroup of
non-TopLevelItem.

This is the case for instance when encountering a MavenModuleSet which
is ItemGroup<MavenModule>
2013-04-29 10:17:36 +05:30
Kohsuke Kawaguchi 6327e265f8 Added the set-build-parameter command. 2013-04-26 22:03:32 -04:00
ssogabe 0adc32a7e1 fixed typo 2013-04-26 02:35:20 +09:00
Jesse Glick 7fa8fe4096 [FIXED JENKINS-17402] getItem may return null but may not throw IAE. 2013-04-25 11:20:07 -04:00
Jesse Glick 4057463244 [JENKINS-16845] Refinement to hotfix: if build field has already been cleared due to earlier warning, do not throw a new NPE. 2013-04-25 11:11:01 -04:00
Kohsuke Kawaguchi 6e91651a57 [JENKINS-16824] log who's interrupting executors.
This bug indicates that people are having trouble understanding who's
responsible for aborting the build. This change records that
information through the logger.
2013-04-25 07:19:02 -07:00
Kohsuke Kawaguchi 749775311a Oops, that was a debug statement 2013-04-24 12:03:44 -07:00
Kohsuke Kawaguchi 6117578a43 making notes 2013-04-24 12:02:07 -07:00
Kohsuke Kawaguchi 8e6a3f7f03 Converted the build queue and executors into Widgets. 2013-04-24 12:00:58 -07:00
Kohsuke Kawaguchi f1669601e4 [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. 2013-04-24 11:23:37 -07:00
Kohsuke Kawaguchi 6ec5d518cf Added missing attributes 2013-04-24 11:23:37 -07:00
Kohsuke Kawaguchi 33c8ac4d18 this shouldn't be quoted 2013-04-24 11:23:37 -07:00
Jesse Glick 06e459fffe [FIXED JENKINS-17728] ParentBuildAction.parent can sometimes be null. 2013-04-23 20:21:01 -04:00
Jesse Glick 0bf434845b [FIXED JENKINS-17724] /about was not showing licenses.
A recent Stapler update caused the Jelly facet to ignore *.xml.
So need to use raw j:include (as plugins were doing), not st:include (as core did).
2013-04-23 14:46:47 -04:00
Jesse Glick 13461b9359 /about now links to license information for plugins as well. 2013-04-23 13:53:56 -04:00
Jesse Glick 19f34b54d6 -Dhudson.udp=-1 to disable UDP broadcast. 2013-04-23 12:07:31 -04:00
ssogabe 51f952f49c Japanese localization 2013-04-21 20:50:32 +09:00
Kohsuke Kawaguchi 70e1977f21 Call attention to the fact that the security isn't enabled.
This is deemed important because we ship Jenkins without security setting by default.
2013-04-19 14:06:48 -07:00
Kohsuke Kawaguchi 73ee0d3eba Adding more animation 2013-04-19 13:47:39 -07:00
Kohsuke Kawaguchi 4afb1cc0ea adding animation 2013-04-19 13:44:38 -07:00
Kohsuke Kawaguchi 64da3d5e27 simplification 2013-04-19 13:40:46 -07:00
Kohsuke Kawaguchi 937315a29a Delete button will highlight what it is going to delete 2013-04-19 13:36:51 -07:00
Kohsuke Kawaguchi ac7e27756f Avoid using now deprecated names 2013-04-19 12:07:52 -07:00
Kohsuke Kawaguchi 39acb350c1 make this row always stick to the top 2013-04-19 12:05:29 -07:00
Kohsuke Kawaguchi 368d8c7394 Don't let the error icon get clipped when the text is short.
On Chrome (and possibly others), an inline element like span doesn't enlarge
its size to cover its content, so the 1px place holder wasn't taking effect.

To ensure the minimum height of 16px, make it an inline-block element. I'm
not entirely sure how an inline-block element with no fixed width would behave,
but with a bit of casual testing, the text inside seems to wrap OK.
2013-04-19 10:11:28 -07:00
Kohsuke Kawaguchi 22d1175ac6 Show when the monitor data was obtained 2013-04-18 19:21:56 -07:00
Kohsuke Kawaguchi 58cb75fd28 Improved the robustness in the node monitoring
- Improved logging and recovery for the Record thread that dies in the middle.
- Recover from failing to monitor one node and move on to the next.
2013-04-18 18:54:15 -07:00
Kohsuke Kawaguchi 5c95be34e4 don't let a programming error kill this thread 2013-04-18 18:39:18 -07:00
Kohsuke Kawaguchi e131764850 formatting improvements 2013-04-18 18:09:58 -07:00
Kohsuke Kawaguchi b1f0a7be75 Adding more diagnostics logging 2013-04-18 15:36:02 -07:00