Commit Graph
10778 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 7578aa93ad expose the display name of the build as environment variable 2013-04-18 10:38:20 -07:00
Kohsuke Kawaguchi 070f74f667 making this extension point more discoverable 2013-04-17 16:25:47 -07:00
Kohsuke Kawaguchi 3abc50253a 46b6bee16e left this comment that's no longer meaningful. 2013-04-17 13:52:35 -07:00
Kohsuke Kawaguchi e36a075436 Improve the error message to indicate which file had failed to parse.
This allows administrator to remove this problematic file.
2013-04-17 13:51:17 -07:00
Kohsuke Kawaguchi 3f4d82a1a3 Adding a new item should cause the dependency graph recalculation.
For example, a new job might have a trigger setting to begin with,
or it might resolve a reference that was previously failing (for
example, 'up' job referring to 'down' job and the 'down' job is newly
created.)
2013-04-17 09:55:12 -07:00
Kohsuke Kawaguchi 46b6bee16e pointless double invocation 2013-04-17 09:08:52 -07:00
Kohsuke Kawaguchi 5f806d8f63 Marked various mode-link as inside.
Observations:

- When marked inside, moving the mouse to <A> and clicking the context menu becomes easier,
  because you can move the mouse toward the hot spot area and it'll activate.
  Otherwise you have to move the mouse over to <A>, then move the mouse on the side, click it,
  then click the menu, which adds cognitive stress.

- Marking model link as inside creates an empty space to the right of <A>, which looks
  odd if hyperlinks appear inline or if some other text follows it.

Given that, my guiding principle for this change is:

- any model link that is the last child of a block element gets marked as inside
- I've adjust a few text to get rid of the single-letter training text after a model link,
  like "(#3)" to "- #3"
- If another inline element follows a model link, leave it as is.
  This does create an ugly overlap.
2013-04-16 20:09:09 -07:00
Kohsuke Kawaguchi e6ee4abc84 Forgot to commit this image. 2013-04-16 19:28:15 -07:00
Kohsuke Kawaguchi 63b3c935ef Use transparent background in the title logo.
This prevents one pixel height difference between the logo and the title
bar background.
2013-04-16 19:27:36 -07:00
Kohsuke Kawaguchi 24aa5a54be adding more ModelObjectWithChildren implementations 2013-04-16 18:59:15 -07:00
Kohsuke Kawaguchi 304ffabed2 implemented ModelObjectWithChildren in various model object implementations 2013-04-16 18:50:33 -07:00
Kohsuke Kawaguchi e6da4f7773 BUG: z-index of the context menu must be bigger than that of the menu selector.
And both values need to be still bigger than the z-index of the top sticker
since the breadcrumb bar is on the top-sticker
2013-04-16 17:58:46 -07:00
Kohsuke Kawaguchi 89621a90d6 BUG: z-index of the context menu must be bigger than that of the menu selector 2013-04-16 17:52:27 -07:00
Kohsuke Kawaguchi b2cd4120ec Breadcrumb is reworked to show descendants to provide additional navigational shortcuts.
Object that implements ModelObjectWithChildren can expose its children in the breadcrumb.
2013-04-16 17:51:15 -07:00
Kohsuke Kawaguchi 0f6b02bd18 Modifying the breadcrumb context menu so that it also requires clicking 'v'. 2013-04-16 17:10:09 -07:00
Kohsuke Kawaguchi 69835e0f8a Additional 'inside' class allows pre-allocation of the context menu space 2013-04-16 16:57:16 -07:00
Kohsuke Kawaguchi 8b8ea1c77b Elements passed in are already extended via Prototype 2013-04-16 16:48:01 -07:00
Kohsuke Kawaguchi 9cddeba7b2 [JENKINS-13995]
Made the 'v' icon bigger to increase the hit test area, and improved the alignment
logic so that the text and the 'v' icon gets vertically aligned.
2013-04-16 16:43:27 -07:00
Kohsuke Kawaguchi 11bc7ce933 [JENKINS-13995]
Now that the context menu is open only when clicking 'v', the tooltip on model link should
be displayed as soon as the mouse hovers over it.
2013-04-16 16:00:46 -07:00
Kohsuke Kawaguchi 5aa4af75c2 we want to prefer *.jpi over *.hpi, but the code was other way around 2013-04-16 13:38:54 -07:00
Kohsuke Kawaguchi 38eec41601 Simplification without changing the semantics 2013-04-16 12:56:37 -07:00
Kohsuke Kawaguchi ff7f272a4b Fixing StringIndexOutOfBoundsException
I'm not really sure what this code is doing or what ID is supposed to look like. So this is just a minimum-intrusion change to avoid an exception.

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1875)
        at hudson.tasks.junit.PackageResult.findCorrespondingResult(PackageResult.java:86)
        at hudson.tasks.junit.TestResult.findCorrespondingResult(TestResult.java:295)
        at hudson.tasks.test.AbstractTestResultAction.findCorrespondingResult(AbstractTestResultAction.java:183)
        at hudson.tasks.test.TestResult.getResultInBuild(TestResult.java:162)
        at hudson.tasks.junit.History.getList(History.java:82)
        at hudson.tasks.junit.History$1.createDataSet(History.java:105)
        at hudson.tasks.junit.History$GraphImpl.createGraph(History.java:169)
        at hudson.util.Graph.render(Graph.java:87)
        at hudson.util.Graph.doPng(Graph.java:98)
2013-04-16 12:56:37 -07:00
Jesse Glick 5ee9ab5451 Merge pull request #760 from mpapo/JENKINS-17416
JENKINS-17416 - Improve Wipe Out Workspace label
2013-04-16 12:48:32 -07:00
Kohsuke Kawaguchi 084da443e1 [JENKINS-13995]
Added logging more liberally, and fixed the problem.
The root cause was that when the mouse enters a hot spot, I wasn't cancelling the previous delayed hide timer.

This fix eliminates the need for the hack in the hide method where I was testing if the mouse was still over the hotspot.
2013-04-16 12:04:34 -07:00
Kohsuke Kawaguchi 6fb7a50d07 [JENKINS-13995]
Fixed a bug where the context menu anchor 'v' disappears even when the mouse is still over a model link.
2013-04-16 12:03:47 -07:00
Kohsuke Kawaguchi d9ec2ce7f3 matching the size with font size since the context menu is most likely aligned with text 2013-04-16 12:03:47 -07:00
Kohsuke Kawaguchi 7547681a24 need to prefer linked files over archives.
This regression appeared to be introduced in 32d5c23.
2013-04-16 12:03:47 -07:00
Michael Pailloncy 15cc52276e JENKINS-17416 - Improve Wipe Out Workspace label 2013-04-16 19:59:32 +02:00
Jesse Glick f8ce8c6e5a Removed junk from cdee827d55. 2013-04-16 11:55:58 -04:00
Nicolas De loof cdee827d55 restore backward compatibility
d3096819f6 changed constructor signature. Add a backward-compatible one
2013-04-16 13:52:23 +02:00
ssogabe 3a855b876d updated Japanese localization 2013-04-13 19:40:42 +09:00
ssogabe ac562d821a check view name with ajax 2013-04-13 09:53:51 +09:00
Seiji Sogabe 477e8979eb rawEncode should be used instead of encode 2013-04-13 04:48:07 +09:00
Jesse Glick 299af75293 Touch-ups related to PR #757. 2013-04-12 14:09:12 -04:00
Vincent Latombe bcd9456933 Merge branch 'master' into views_include_jobs_folder 2013-04-12 15:56:11 +02:00
lvotypko 095ef2d7ee Keep consistence in pendings when exception is thrown during method pop() 2013-04-12 07:53:53 +02:00
Jesse Glick 7d31e7c5d6 Using l:confirmationLink instead of AbstractItem/delete.jelly and AbstractProject/wipeOutWorkspace.jelly. 2013-04-11 17:45:40 -04:00
Jesse Glick 704d870a13 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-04-11 11:36:30 -04:00
Jesse Glick 1205e9f6c4 [FIXED JENKINS-17575] Redirecting properly after deleting jobs in folders.
Expanded MockFolder to be a ViewGroup so that it is possible to test views inside folders,
and generally fixed it to service Stapler hierarchies properly so that WebClient-based tests can work.
2013-04-11 11:34:56 -04:00
Seiji Sogabe c86b6d7055 Merge pull request #657 from ssogabe/JENKINS-5408
[FIXED JENKINS-5408] Quoting Issue with JDK Installer with Windows Slave
2013-04-11 08:21:27 -07:00
Jesse Glick e3346be374 Better toString. 2013-04-11 11:07:51 -04:00
Vincent Latombe c4847d1b95 Deprecated jobBaseUrl from projectView.jelly.
The reason is that we always determine the job url using
Functions#getRelativeLinkTo, which keeps the view navigation info if it
exists, and can produce an absolute url if required by the context. So
it is no longer needed for the caller to worry about jobBaseUrl.

By default, names are interpreted in relatively to the current item
group, so Label and Computer views no longer need to set useFullName to
true to have correct behaviour.
2013-04-11 09:19:10 +02:00
Seiji Sogabe d33e22d392 [FIXED JENKINS-17317] ”My Views" links leads to 404 Not Found. 2013-04-11 06:31:21 +09:00
Vincent Latombe 719975595d Merge branch 'master' into views_include_jobs_folder
Conflicts:
	changelog.html
2013-04-10 19:00:04 +02:00
Jesse Glick 9eb69772a5 [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive.
First of all, /reload should require POST (also prevents XSS DoS attacks).
Adding <l:confirmationLink> to encapsulate a link that requires confirmation upon clicking.
Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown.
Enhancing <l:task> to support confirmation as well, and honoring this in context menu items.
2013-04-10 11:29:18 -04:00
Vincent Latombe 609487a06f Merge branch 'master' into views_include_jobs_folder
Conflicts:
	changelog.html
2013-04-10 14:30:27 +02:00
Vincent Latombe 0c0959ec10 Call non-ambiguous method 2013-04-10 11:47:15 +02:00
Vincent Latombe d54105c296 Crafting the job parent url by removing the job short url to the
complete relative url, in order to take into account the current view.
2013-04-10 11:27:59 +02:00
Vincent Latombe f6cc507217 Functions#getRelativeLinkTo now normalize the output url.
Added some unit tests
2013-04-10 11:27:10 +02:00
Vincent Latombe a1adf8aeab Removing allJobNames.
The view content needs to be determined by getItems as the content can
change even without view definition modification.
2013-04-10 09:47:10 +02:00