fix(settings): expose provider startup limits for binary open (#10105)

This commit is contained in:
morluto authored and GitHub committed 2026-11-11 20:19:27 +08:00
1 parent ab8e31dc76
commit 48357cb34c
2 files changed
+14

No files matched your search

+11
View File
@@ -163,6 +163,17 @@ it("exposes shared provider controls and preserves the explicit unbounded decomp
REA_GHIDRA_DECOMPILE_MAX_PAYLOAD_MIB: "64",
};
const store = new AnalysisSettings(environment);
for (const provider of ["ghidra", "hopper"] as const)
expect(
store
.inspect({ provider, operation: "open_binary" })
.settings.map(({ setting }) => setting),
).toEqual(
expect.arrayContaining([
`${provider}.startup_timeout_ms`,
"bridge.max_request_bytes",
]),
);
const parsed = parseConfig(environment);
if (!parsed.ok) throw parsed.error;
const config = runtimeAnalysisConfig(parsed.value, store.read);
+3
View File
@@ -227,6 +227,7 @@ export const ANALYSIS_SETTINGS = {
appliesAt: "next_startup",
provider: "ghidra",
operations: [
"open_binary",
"binary_overview",
"list_documents",
"list_procedures",
@@ -248,6 +249,7 @@ export const ANALYSIS_SETTINGS = {
appliesAt: "next_startup",
provider: "hopper",
operations: [
"open_binary",
"binary_overview",
"list_documents",
"list_procedures",
@@ -372,6 +374,7 @@ export const ANALYSIS_SETTINGS = {
// Cutter bridge calls. bridgeMaxRequestBytes.test.ts fails when a registry
// gains an operation that is missing here.
operations: [
"open_binary",
"address_name",
"comment",
"current_address",