Commit Graph
8363 Commits
Author SHA1 Message Date
RRFZandmorluto f192180fb5 refactor(desktop): pass export task reader runner through a port (#11858)
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 19:31:12 -05:00
ShuaixinHuang 0c83de1642 fix(desktop): preserve ELF filesystem lookup bytes (#12108) 2026-11-18 19:24:16 -05:00
ShuaixinHuangandShuaixinHuang 229fc6aae8 fix(ci): synchronize CDP handshake and attach deadlines (#12110)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 19:23:46 -05:00
RRFZ 2076b7bf88 refactor(desktop): inject HostFileReader port into build solve and witness (#11880)
refactor(desktop): inject HostFileReader port into build solve and witness workflows
2026-11-18 19:22:40 -05:00
morluto 21829964ef fix(kuna): recover explicit direct-call destinations (#12106)
* fix(kuna): recover explicit direct-call destinations

* fix(kuna): preserve call evidence on decompile failure
2026-11-18 19:07:02 -05:00
morluto b44d949bfe feat(kuna): verify release 1.1000 (#12107) 2026-11-18 18:52:55 -05:00
David Muñoz Rey 15090cf848 docs(i18n): fix two Spanish strings flagged in review of #12103 (#12104)
The FAQ sentence put an imperative before a link whose text is also an
imperative ("Consulta Usa la CLI"); the link now reads "cómo usar la CLI".
The TH04 figure label coordinated two singular adjectives after a plural
noun; it now names each ring.
2026-11-18 18:42:15 -05:00
Nianze Wu c6033aaaca fix(desktop): bound exported XML selector traversal (#12105) 2026-11-18 18:41:18 -05:00
e3713bea60 feat(rust): read cargo-auditable dependencies from WebAssembly modules (#5069)
* feat(rust): read cargo-auditable dependencies from WebAssembly modules

cargo-auditable embeds the same zlib-compressed `.dep-v0` JSON in a
WebAssembly custom section for wasm32 targets, but inspect_rust_binary
rejected every module as an unsupported target because only ELF, PE and
thin Mach-O containers were recognized.

Walk the section framing of version 1 core modules to locate the
`.dep-v0` custom-section payload and the data section, where rustc keeps
its constant /rustc/<hash>/ paths. Rust lookups now read one
format-neutral layout, so native and WebAssembly images share a single
dependency-section owner. WebAssembly declares no container word size, so
`bits` is null for that format only; the Evidence subject format is
`file`, as for inspect_wasm_artifact.

Truncated sections, invalid LEB128 sizes, custom-section names that run
past their section or are not UTF-8, duplicate `.dep-v0` sections and a
second data section are malformed. Components, such as wasm32-wasip2
output, embed core modules and are refused as unsupported, like universal
Mach-O containers, rather than inspected through one selected module.

* fix(rust): bound the WebAssembly section walk

The WebAssembly reader visited every section synchronously, and the format
sets no section count. A 256 MiB input of three-byte custom sections with
empty names walked about 89 million sections and held the event loop for
about 7.4 seconds, delaying cancellation and other MCP requests; empty type
sections took about 1.9 seconds.

Refuse a module with more than 65,536 sections with a typed cpu resource
constraint that reports maximum_wasm_sections, as the Go header search
reports its work budget. Producer output holds a few dozen sections, and the
same inputs are now refused within tens of milliseconds.

* fix(rust): accept WebAssembly Evidence in retained dependency views

Retained Rust views compared the parent subject with a Mach-O-only format
mapping, so WebAssembly Evidence, whose subject format is file, was refused
as a different artifact. The report domain now owns the subject format next
to the architecture mapping, and the service and the view both use it. The
real CLI/MCP view workflow now also covers a WebAssembly module.

* fix(rust): name the WebAssembly section-walk allowance in recovery

Fixed-allowance recovery mapped every Rust resource other than capacity and
transport to the parser allowance, so the section-walk refusal said host
memory does not raise it. Each Rust resource now maps to its own allowance,
and the cpu bound is a fixed work allowance. The MCP error contract test
checks that the refusal is not retryable and names that allowance.

* fix(rust): require WebAssembly container facts in reports

The report schema tied a null word size to WebAssembly, but it accepted a
wasm report that named a native architecture or big-endian byte order, and
a native report that named the wasm architecture. Retained views parse
imported Evidence with this schema, so such a contradictory report was
accepted. The architecture is now wasm exactly when the container is
WebAssembly, and a WebAssembly report must be little-endian.

* docs(rust): record the WebAssembly dependency-metadata feature

Feature work now carries a spec, plan and task list under docs/specs.
This adds that record for reading cargo-auditable metadata from
WebAssembly core modules and indexes it. The record states that it was
written during review and lists the verification that remains open.

* fix(rust): bind section names to containers and share the LEB128 reader

The report schema accepted a dependency section name that does not belong
to the report's container, such as a WebAssembly report naming the Mach-O
section. rustDependencySectionName now owns that name for the reader and
the schema, which refuses a mismatch for every container.

The WebAssembly reader decoded section sizes with its own loop. It now
uses the shared readLeb128, and an integer cut off by the end of the file
is truncated rather than malformed.

* fix(rust): classify a cut-off WebAssembly integer by its boundary

The reader called an unfinished LEB128 integer truncated whenever its
limit equalled the file length. A name length cut off inside the final
section was therefore truncated, and the same bytes followed by another
section were malformed. Each caller now states whether the file or the
enclosing section bounds the integer.

* fix(rust): report a duplicate WebAssembly dependency section first

The section walk kept two .dep-v0 matches but walked on, so a module with
two dependency sections and more than 65,536 sections after them was
refused for the section bound instead of the duplicate it had already
established. The walk now ends at the second match.

* test(rust): assert WebAssembly container facts instead of limitation prose

The CLI acceptance test matched an English limitation sentence. It now
checks format, architecture, bits and byte order on the parsed report.

* fix(rust): state container word size as 32 | 64 | null

Output contract: inspect_rust_binary bits, including the summary view, is
32 | 64 | null. Null is valid only for WebAssembly and is not a number.
ELF, PE and Mach-O reports stay 32 or 64. The schema description, guide,
feature record and skill state that, and CLI renderers keep null instead
of substituting a word size.

---------

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-18 18:29:31 -05:00
morluto e09d6273a1 fix(native): preserve caller-selected paths in binary sessions (#12102)
* fix(mcp): preserve caller-selected binary session paths

* test(mcp): verify caller paths across snapshot replay

* test(mcp): separate session alias and snapshot replay coverage

* fix(evidence): preserve selected paths across binary workflows

* fix(evidence): retain authentication admission for caller aliases
2026-11-18 18:27:29 -05:00
David Muñoz Rey c3531b9f1c docs(i18n): review the Spanish guides, case studies and blog (#12103)
* docs(i18n): complete the Spanish website translations

The Spanish catalog had 63 of 1,808 messages without a translation, so the RL environments guide and a few setup sentences fell back to English in the Spanish edition.

They are translated now, with the wording the catalog already uses for the same terms and the formal address most of its pages use.

* docs(i18n): fix spacing and separators in the Spanish website catalog

About 210 Spanish messages carried marks of an automated pass: a space before punctuation or inside parentheses ("REA .", "( Windows )"), a space between a name and the tag that closes it, doubled spaces, and an asterisk where the source has a middle dot ("01 * Tú").

The spacing next to each placeholder now follows the source message, the stray spaces are gone, and the middle dot is restored. No wording changes.

* docs(i18n): review the Spanish onboarding pages

Read the home page, Get started, Your first investigation and the dinosaur
speed lab in full, with the shared navigation and interface messages. These
pages mixed the informal address of the edited strings with the formal
address of the initial draft; they now use the informal one throughout.

Fixes wrong-sense words (sucursal for a code branch, cheque for a check,
punto final for an endpoint), broken placeholder order, copy-button labels
and the stale translation of the RL environments task line.

* docs(i18n): fix wrong-sense words in the Spanish website catalog

Outside the onboarding pages, replace words found by search that carry the
wrong sense: cheque for a check, punto final for an endpoint, camino for a
path, puerto for a software port, and codificación in coding agent. Rewrite
the sentences around them where articles, placeholder order or other words
were broken, and use the navigation's Casos prácticos in the breadcrumbs.

* docs(i18n): keep the ownership sense of owned protocol stdin in Spanish

The Aegis setup sentence rendered "owned protocol stdin support" as support
for the protocol's own stdin, which drops who owns the process. Say that the
package must accept protocol stdin for the processes REA starts and controls.

* docs(i18n): review the Spanish guides and FAQ

Read the guides index, the native, browser, JavaScript and RL environments
guides and the FAQ in full against their source. They now use the informal
address and the terms of the edited strings (prompt, skill, la CLI, agente de
programación), and the Notes button keeps its on-screen label.

Fixes wrong-sense renderings such as "la persona que llama" for a caller,
"guión" for a script, "grabadora CSV" for the CSV writer and the
translated field name in summary.ipc, and broken placeholder order.

* docs(i18n): call the browser capture block a command in its copy label

The block copies a terminal command, not a prompt.

* docs(i18n): review the Spanish case studies

Read the case-study index and the Aegis, CTF, DX-Ball, Notion and TH04 case
studies in full against their source, with their three figures. They now use
the informal address and the terms of the edited strings.

Fixes wrong-sense renderings such as "viñetas" for bullets, "rebajas" for
Markdown, "bandeja de sonido" for sound pan, "tienda" for a store
instruction, "asamblea" for assembly and "PRINCIPAL.EXE" for MAIN.EXE,
keeps path and field names as written, and repairs placeholder order.

* docs(i18n): keep the DX-Ball figure labels inside their boxes

Three Spanish labels were wider than the boxes drawn for them. Shorten the
title, the caller label and the matching-bytes label.

* docs(i18n): review the Spanish blog essays

Read the blog index and the two essays in full against their source. The
Touhou reconstruction essay is retranslated: it rendered RE as augmented
reality, a ledger as an accounting book, game titles as literal phrases and
compounding as getting worse. The models essay, already edited, gets term
fixes: control-flow graph, compiler feedback, training, floating point.

Imperatives addressed to the reader use the informal address, and the
author's first-person voice is kept.

* docs(i18n): keep the setup question in the informal voice

"¿Ya está conectado?" read as formal address next to informal imperatives.
Ask it of the reader in the informal form.
2026-11-18 18:15:09 -05:00
IvenKooandmorluto 27db243533 fix(static): keep quoted sample text out of the tech-debt marker scan (#11712)
fix(static): read comments instead of quoted text in the tech-debt scan

`npm run scan:todos` matched raw text, so a marker quoted inside a sample
string counted as debt: on `main` at a10037ef1 the only finding is the
JavaScript sample in
`tests/boundary/filesystem/mcpClientValidationGuard.test.ts`, and the
`Deep static checks` lane is red for every PR that runs it.

Decide what a comment is before counting a marker. JavaScript and TypeScript
are parsed with `@babel/parser`, whose comment ranges also survive a quote
inside a regex literal; `bridge/**/*.py` and `bridge/**/*.java` use a small
scanner that skips quoted and triple-quoted strings. Markers are matched per
occurrence, so a quoted marker earlier on the line no longer consumes a real
one, and an unparsable file stays conservative: every marker counts.

Fixes #11717.

Verified: `npm run scan:todos` exits 0 on this tree; the extended
`tests/boundary/process/scanTodos.test.ts` (3 tests) covers a clean tree, a
quoted sample with a real marker on the same line, and comments in
TypeScript, Python and Java. `check:fast` passes.

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 17:54:40 -05:00
00a3f4d2b9 fix(process): preserve Darwin snapshot and cleanup failures (#12100)
* fix(process): preserve Darwin opening snapshot failures

* fix(process): retain the exact Darwin helper cleanup owner

Transfer the failed helper-root capability across repeated prepare failures. Reuse that same owner for retirement and reader close so stale cleanup cannot remove a replacement helper.

Co-authored-by: Anandumv <anandumv@gmail.com>
Co-authored-by: nextjohnp7 <nextjohnp7@gmail.com>

* test(process): isolate retained cleanup and compiler acknowledgements

---------

Co-authored-by: Anandumv <anandumv@gmail.com>
Co-authored-by: nextjohnp7 <nextjohnp7@gmail.com>
2026-11-18 17:34:25 -05:00
morluto 230f86240f docs(browser): describe exact role locator names (#12099)
* docs(browser): describe exact role locator names

* style(browser): format role locator schema metadata
2026-11-18 17:20:26 -05:00
RRFZandmorluto caab34d0de fix(javascript): qualify releases after resource method mutation (#10166)
* fix(javascript): qualify releases after resource method mutation

* fix(javascript): qualify releases after opaque receiver mutation

* fix(javascript): preserve release ordering and mutation facts

* fix(javascript): order mutations of fresh resource receivers

* fix(javascript): match release mutations to captured receivers

* fix(javascript): check delegated release method identity

* fix(javascript): track paths back to native resource prototypes

* fix(javascript): respect native release member ownership

* fix(javascript): retain shared prototype effects across calls

* fix(javascript): order release effects after definite acquisition

* fix(javascript): preserve prototype effects across receiver replacement

* fix(javascript): preserve native release identity across proven effects

* fix(javascript): preserve shared prototype uncertainty after opaque calls

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 17:02:04 -05:00
ClarkandClark 2191896f3b docs(i18n): complete zh-CN translations including rl-environments (#12079)
Co-authored-by: Clark <301422770+clark970417-eng@users.noreply.github.com>
2026-11-18 16:54:04 -05:00
David Muñoz Rey 1bd45f073c docs(i18n): complete the Spanish website translations (#12092)
* docs(i18n): complete the Spanish website translations

The Spanish catalog had 63 of 1,808 messages without a translation, so the RL environments guide and a few setup sentences fell back to English in the Spanish edition.

They are translated now, with the wording the catalog already uses for the same terms and the formal address most of its pages use.

* docs(i18n): keep the ownership sense of owned protocol stdin in Spanish

The Aegis setup sentence rendered "owned protocol stdin support" as support
for the protocol's own stdin, which drops who owns the process. Say that the
package must accept protocol stdin for the processes REA starts and controls.
2026-11-18 16:53:49 -05:00
Oke Iyanuoluwa Enoch 3a75ee2b1d docs(testing): drop the removed cancelled-constructor baseline (#12098)
#11787 migrated the last direct AnalysisCancelledError constructions and
deleted scripts/verify/baselines/analysis-cancelled-constructor.json, but
the testing guide still told contributors their files were listed there.
State that the guard now has no baseline and allows zero copies.
2026-11-18 16:53:31 -05:00
86cf8942de feat(ghidra)!: import recognized DOS COM files with ComLoader (#12086)
* feat(ghidra)!: import recognized DOS COM files with ComLoader

Select Ghidra 12.2 ComLoader for an admitted .com image and do not pass a
base address, so the file stays at 0000:0100. Images ComLoader rejects use
the explicit BinaryLoader import at 1000:0100 and record the typed reason.

BREAKING CHANGE: A DOS COM file that ComLoader accepts now loads at linear
0x100 instead of 0x10100. Read load_address. The BinaryLoader fallback
remains at 1000:0100.

* fix(ghidra): score COM dollar-strings in one pass

ComLoader's printable-run walk restarts at every offset, so a 64 KiB image
of printable bytes blocked profile resolution. The same capped count now
skips a run once an earlier start has seen every later dollar sign.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): align COM import facts with the image Ghidra receives

Mismatch load-image coordinates follow the measured loader and address.
A dotfile named .com keeps that suffix on the snapshot, and selection
uses that snapshot name. The COM fallback verifier owns its MCP
connection before connect.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* style(ghidra): format COM snapshot and verifier files

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): keep measured COM facts and required MZ coordinates

DOS MZ and a verified COM image keep load_segment and entry required.
A COM mismatch emits a known loader or load address on its own, and
omits the segment and entry only when that pair is not a known layout.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): require the verified COM layout and document both entries

A verified COM image is either ComLoader at 0000:0100 or BinaryLoader at
1000:0100 with a fallback reason. The DOS guide queries 0x100 only for
the ComLoader entry and 0x10100 for the fallback.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): attest COM imports against the committed loader

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-18 16:40:18 -05:00
David Muñoz Reyandmorluto 1920525900 fix(kuna): stop calling executable-segment data sections definite data (#10686)
* fix(kuna): stop calling executable-segment data sections definite data

An address in a Mach-O section whose attributes declare no instructions
was refused as "data that Kuna lists, not a procedure", even when the
section sits in an executable segment. In #8352 a direct call targets
`_placed_in_const` in `__TEXT,__const` (segment initprot r-x), Ghidra
decodes and decompiles it, and REA's own procedure_callees reports the
call, yet the Kuna refusal asserted it categorically as data.

The Mach-O layout now records, for each data placement, whether its
enclosing segment's initial protection includes VM_PROT_EXECUTE. For such
placements the refusal keeps the section declaration and the
classification, but says REA's Kuna lane does not treat the entry as a
procedure and that the declaration alone does not prove the bytes are
not code; its remediation adds the Ghidra provider as a decoding route.
address_name's limitation is qualified the same way. Non-executable
segments and the Mach-O header keep the existing wording. Procedure
tools still refuse these entries; making them followable is left open.

Validation: kunaMachoInventory and kunaInventoryPlacement boundary tests
cover the executable `__TEXT,__const` entry, its remediation and
address_name limitation, and an unchanged `__DATA` control. The full
Kuna boundary directory shows the same 11 environment-related failures
on unchanged main as on this branch; check:fast passes.

Refs morluto/rea#8352

* fix(kuna): keep the executable-segment caveat when a refused name is shared by data entries

Review follow-up: a name that several data entries share took a grouped refusal that still said "they are data, not procedures" and offered no Ghidra route, even when one entry lies in an executable segment. The grouped message and remediation now come from KunaInventoryPlacement beside the single-entry ones: with an executable placement they keep the caveat and the Ghidra route, and otherwise the wording is unchanged.

Tests: a shared-name case with and without an executable-segment entry fails before this change and passes after; the Mach-O inventory tests pass. Five process-lifecycle Kuna test files fail identically with and without this change in this environment.

* fix(kuna): qualify omitted executable-segment inventory entries

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 16:33:55 -05:00
Beqaandmorluto 8c9d29e2ea docs(install): warn against npx from inside a REA checkout (#11285)
* docs(install): warn against npx from inside a REA checkout

A package runner started in the checkout resolves the local rea-agents
package instead of the published install. Document the failure mode and
point contributors at npm link or scripts/rea.mjs.

* docs(install): qualify checkout package runner resolution

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 16:33:50 -05:00
5c59bdc8a6 feat(ghidra)!: verify the bridge on Ghidra 12.2 (#12081)
* feat(ghidra)!: verify the bridge on Ghidra 12.2

Admit 12.x from minor 2 upward, with 12.2 and JDK 25 as the verified
pair. The bridge now calls the four-argument storage API added in 12.2,
so 12.1.x cannot compile it and is no longer accepted.

BREAKING CHANGE: Ghidra 12.1.x is rejected. Use Ghidra 12.2 or another
12.x build at or above minor 2, and a JDK inside that installation's
declared range (25 or newer for the verified 12.2 build).

* docs(ghidra): point remaining lanes at Ghidra 12.2

The Windows, 6502, and m68k prerequisites still named 12.1.4 and JDK 21,
which the verified-build check now rejects. The bridge compile lane names
the 12.2 jars it actually compiles against.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): admit the JDK the verified install declares

The Java home framing probe still reported JDK 21 while the verified
installation fixture now declares a minimum of 25, so doctor admission
failed before the path framing was checked.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): derive admitted install fixtures from the verified release

Boundary hosts and assertions still named Ghidra 12.1.4 after admission
moved to 12.2, so list_procedures evidence and completed property reads
disagreed with the install the provider actually reported.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): record the exact 12.2 Clang switch-recovery defect

Ghidra 12.2 stays the verified build. Sessions and decompiler results on
that exact version name upstream issue 9996 and the 12.2.1 fix commit.
Other version strings, including 12.2.1, do not carry the limitation.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): check switch-defect facts instead of the warning sentence

The policy test keeps the structured defect record and checks that the
owning formatter delivers its id, commit, release, and scope fields.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): name the Playwright launch boundary the lifecycle catalog checks

Main retitled that case with a platform placeholder. The coverage catalog
still required the old literal, so the merged full suite reported a missing
title.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): point the lifecycle catalog at main's launch title

The merged suite uses main's platform-specific Playwright launch test.
The coverage catalog now names that title, and this branch keeps main's
test body so the merge stays clean.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): cover the platform launch title on this branch

The lifecycle catalog names main's platform launch title. This branch
now has that quoted test too, so the check passes before and after the
merge.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): record the exact 12.2 masked byte-switch defect

Ghidra 12.2 leaves an AArch64 and-0xff byte-offset switch unrecovered.
Exact 12.2 sessions now cite open upstream issue 10154, and the AArch64
lane expects that jump table to stay unrecovered.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): keep one platform launch environment check

The second launch test repeated the selected environment check. The
remaining test is the parameterized title, and the launcher forwards
SYSTEMROOT on win32 so that assertion holds.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): keep the open switch defect on admitted builds

The exact-version check cleared ghidra-10154 on every build except 12.2.
That defect stays on admitted releases until one is known to fix it.
ghidra-9996 still clears after the exact 12.2 build.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* style(docs): format the Ghidra testing-lane table

The AArch64 jump-table row wrapped past the formatter width and failed
static checks.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): give the masked switch its full byte range

The unrecovered oracle now uses 256 readable table bytes, and the same
object must still recover its compare-bounded switch.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* docs(website): point Ghidra setup at 12.2 and JDK 25

The public setup pages still told new users to install Ghidra 12.1.4 and
JDK 21, which this release rejects. Changed setup sentences are extracted
and left untranslated so those editions use the English page.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* docs(website): keep catalog edits to the changed setup strings

The catalog check compares active message ids, not a full rewrite.
Restore the previous catalogs and update only the Ghidra 12.2 setup
strings, leaving their translations empty.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): apply the closed switch defect from the parsed patch

12.2, 12.2.0, and 12.2.0 with a suffix all precede 12.2.1, so they keep
ghidra-9996. The masked-switch table lists all 256 byte entries.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): share the AArch64 switch fixture compiler invocation

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-18 16:06:51 -05:00
635a87a4f4 fix(verify): scrub ambient npm install-policy from verifier child npm environments (#10474)
* fix(verify): scrub ambient npm install-policy from verifier child npm environments

* fix(verify): keep caller npm policy for script-enabled commands

---------

Co-authored-by: LexLuthorPrimero <1@voidmail.io>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:33:46 -05:00
Saim Shafiqueandmorluto 731049ab9c fix(windows): gate transient writes on runtimeWriteTransient capability (#10607)
* fix(windows): gate transient writes on runtimeWriteTransient capability

A source checkout and the published 6.8.0 addon share package version
and native ABI 1, so the loader admits the older addon. JavaScript
staging then fails at source-transfer with Win32 87 because the addon
has no runtime_write_transient operation.

Native inspection now advertises runtimeWriteTransient, the loader
accepts it only as literal true, and writeTransientFile refuses before
dispatch with a typed nonretryable error pointing at an exact-source
rebuild. Older addons stay admitted for the controls they support.
Recovery text no longer presents a same-version tarball as enough for
an unreleased checkout.

Fixes #9286

* test(ghidra): expect the new native-authority remediation wording

The #9286 fix changed the doctor recovery text so a same-version
tarball is no longer presented as enough for an unreleased checkout;
the pinned expectation still asserted the old wording.

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:28:36 -05:00
morluto b60836a157 ci: retire the automated PR readiness check (#12095)
* ci: retire the automated PR readiness check

* ci: remove the retired readiness module declaration
2026-11-18 15:27:23 -05:00
Ahmedandmorluto dc6799d488 fix(android): report method disassembly failure as unavailable body (#12090)
* fix(android): report method disassembly failure as unavailable body

Catch JADX bridge get_method_body failures in inspectMethod and project as an unavailable body with disassembly_failed marker, avoiding generic execution_failure with irrelevant rea doctor remediation.

Fixes #10482

* fix(android): preserve method identity when disassembly is unavailable

* fix(android): retain method identity when smali generation fails

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:23:34 -05:00
486470ec9b fix(desktop): preserve cancellation after ELF lookup refusals (#11804)
* fix(desktop): resolve needed origins before library deduplication

* fix(desktop): resolve library paths through filesystem

* fix(desktop): retain package ownership of required library links

* fix(desktop): traverse hard-linked dependencies once

* fix(ci): isolate expensive capacity regressions from parallel workers

(cherry picked from commit a1f762d1139f51d97130f8c20cfb12d567cced72)

* fix(desktop): preserve complete library lookup semantics

* fix(desktop): retain required directory alias owners

* fix(desktop): preserve ownership across complete library link routes

* fix(desktop): share merged-system ownership lookup for link entries

* test(mcp): observe cleanup failures at their current delivery boundary

* fix(mcp): preserve workflow completion progress through delivery

* test(setup): keep the Windows Kimi profile fixture on a supported profile

The Windows-only case at `clientConfigurationEnvironment.test.ts:226` wrote
`rea_mcp_input_schema_profile: "full"`. That profile was retired: the reader
now refuses it ("REA_MCP_INPUT_SCHEMA_PROFILE accepts only \"compact\" …"),
so `configureClientConfiguration` returned `failed/readback` before writing
and the case failed on every Windows run, including main's own
`Windows capability and package lane`.

The case has no Windows dependency — it passes an explicit `configPath` and
the Kimi write dialect is the same everywhere — so it now runs on every
platform, which is what let the stale value rot unnoticed. The fixture keeps
the lowercase explicit key the case is about, with the supported value.

Verified on `main` `d6bcfc10`: the same fixture driven through
`configureClientConfiguration(..., "win32")` on this host reproduced
`{"status":"failed","reason":"readback"}` with the retired value and now
returns `{"status":"configured"}` with `compact`. The file's 75 cases pass
here (66 run, 9 platform-conditioned skips) and `check:fast` passes.

* test(ci): restore verifier and MCP contract regressions

* test(captures): assert adapter-owned input issue field names

* fix(ghidra): avoid Java probes for missing installations

* fix(desktop): retain all selected leaf ownership spellings

* fix(desktop): retain link target ownership contexts

* fix(desktop): retain successful lookup retries and cancellation

* fix(desktop): preserve library probe failures and cancellation

* fix(desktop): preserve cancellation after lookup refusals

* docs(desktop): clarify library lookup error precedence

* fix(desktop): check library budget before absolute path lookup

* fix(desktop): report each unowned library path once

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: g0at <50488370+g1at@users.noreply.github.com>
Co-authored-by: IvenKooLab <276572622@qq.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:18:59 -05:00
David Muñoz Rey cc971d6df5 feat(domain): classify 64-bit PowerPC ELF (EM_PPC64) in the powerpc family (#12089)
* feat(domain): classify EM_PPC64 ELF in the powerpc family

An ELF with e_machine 21 was refused as "unsupported ELF architecture" before any provider was consulted, so every entry point answered a 64-bit PowerPC file with the generic file-format refusal.

The header reader now places EM_PPC64 in the powerpc family and keeps its class, byte order, e_type and e_flags as it does for EM_PPC. No provider lane admits these files: the Ghidra PowerPC gate already refuses ELF64 by naming PPC64, and Hopper, IDA and Kuna decline the family. Static ELF readers keep the name ppc64 for the machine.

Refs morluto/rea#12085.

* feat(domain): map the ppc64 reader name to the powerpc Evidence subject

Static readers report a 64-bit PowerPC ELF as ppc64, and the Evidence subject of those reports had no architecture because the name mapped to no family. With EM_PPC64 classified as powerpc, the subject now carries that family, as it does for ppc.

The Go verifier and the Go and Rust guides state the new mapping, and the boundary test keeps an unknown machine (s390) to show that unrecognized names still map to no family.

Refs morluto/rea#12085.

* revert(domain): keep ppc64 reader reports without a subject family

This reverts commit bbd7f7f661.

Evidence saved before the mapping carries no subject architecture for a ppc64 report. Views over those records compare the saved subject with the family the reader name maps to, so the mapping made them refuse records they accepted before. Nothing in this branch produces Evidence that needs the family, so the mapping can wait for a provider lane.

Refs morluto/rea#12085.

* fix(domain): classify EM_PPC64 only for an ELF64 header

Classifying machine 21 by number alone had two effects beyond target resolution. An ELF32 big-endian ET_EXEC header that claims EM_PPC64 became a powerpc target with class 32, which the 32-bit Ghidra lane admits because it sees only class, byte order, type and flags. And every static reader that maps a machine to a family started to put powerpc in its Evidence subject, which changes what views expect from records saved earlier.

elfArchitecture now takes the ELF class and names the family for machine 21 only when the caller commits ELF64. Header admission passes the class. Readers that pass only a machine keep the machine unclassified, so their reports, reader names and Evidence subjects are as they were.

Refs morluto/rea#12085.
2026-11-18 15:13:05 -05:00
93fb79e3b8 fix(ci): preserve conformance subprocess cleanup ownership (#12025)
* fix(ci): preserve conformance subprocess cleanup ownership

* test(ci): use a token-observable conformance child

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:08:58 -05:00
morluto a51ce1390d test(browser): track the platform-specific lifecycle coverage case (#12093) 2026-11-18 15:06:43 -05:00
吴佳浩Albenandmorluto 1e0f3348a7 fix(process): name the fields a located divergence compared (#11813)
* fix(process): name the fields a located divergence compared

`first_divergence` handed back the whole observation on each side, so a
caller that saw `changed` had to diff two large objects by hand to learn
what the comparison actually judged. Reported in #8204: the same
deterministic CLI captured twice reports `terminal`, `exit`, and
`filesystem` changed, and the report names no field.

A located divergence now carries `fields`, the sorted leaf paths that
differ in the projection the comparison judged, for example
`files[3].path`, `pid`, `process_samples[0].pid`, or `$` when a whole
observation is present on one side only. Positions are bracketed array
indices; the list is bounded to eight names because the report names a
difference rather than copying the observation, and `left` and `right`
still retain both complete observations.

The list is computed from the comparable projection, not the observed
values, so capture-local timing (`at_ms`, `dispatched_at_ms`,
`elapsed_ms`, `sent_at_ms`) is never named unless a `trace_spec`
explicitly selects it. That keeps the names honest about what the
comparison measured.

Naming a volatile value is not a claim of equivalence. A per-run
temporary root or PID still counts as a difference; the exclusion path
remains capture-time normalization (`normalization.paths`,
`normalization.pids`, `normalization.patterns`), which must match on both
sides because comparison refuses captures under different rules.

`fields` is optional in the contract. `readComparisonResult` re-validates
`normalized_result` of authenticated Evidence, so a required field would
reject records written before this change. Producing code always
populates it.

Validation: `tsc --noEmit` clean; `oxlint` reports only the four
pre-existing complexity/length warnings this file already carried;
`scripts/ci/static-check-report.mjs lint` 0 errors; module boundaries and
architecture guards pass; `oxfmt --check` clean on the touched files;
`completeness-enum-guard`, `optional-fact-default-guard`, and
`rea-numeric-limits` pass; `scan:todos` and `verify-test-discovery`
clean; jscpd within budget. 194 focused domain tests passed, including
five new cases covering a temporary-path leaf inside a filesystem
checkpoint, a fully populated process sample, the eight-name bound,
one-sided presence as `$`, and an authenticated payload without
`fields`. No live process capture was exercised on this host.

Refs #8204

* fix(process): honor trace timing policy in divergence fields

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:05:59 -05:00
ShuaixinHuangandShuaixinHuang 6d66f3a8ee fix(artifacts): preserve PyInstaller retirement and map identity (#11830)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:59:57 -05:00
ShuaixinHuangandShuaixinHuang 0db5f93df6 fix(protobuf): preserve descriptor string identity (#11834)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:59:49 -05:00
ShuaixinHuangandShuaixinHuang e7ed93004a fix(apk): preserve ambiguous v1 certificate identity (#11835)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:59:41 -05:00
phexussandmorluto fd9989eadb fix(artifacts): keep virtual directory identities distinct from file content (#8574)
A virtual directory node was identified from the SHA-256 of its canonical
listing JSON through the same function as raw file bytes. A regular file
containing exactly that JSON (for example an empty directory's
{"children":[],"kind":"directory"}) received the same artifact ID, the
directory node overwrote the file node, and extraction of the valid
archive failed with an integrity mismatch.

Derive virtual node identities in a separate domain and validate node IDs
by representation. Inventory Evidence retained with the earlier virtual
identity is still accepted.

Fixes #8551

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 14:59:33 -05:00
ShuaixinHuangandmorluto ad02201d0b fix(zip): corroborate member extents before claiming complete coverage (#11855)
* fix(zip): corroborate local member extent claims

* fix(zip): verify descriptors of contained records

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 14:59:28 -05:00
ShuaixinHuangandShuaixinHuang 1290ab401c fix(elf): resolve extended symbol section references (#11924)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:29 -05:00
ShuaixinHuangandShuaixinHuang 954bcd6082 fix(verify): preserve Linux descendant records with multiline names (#11949)
* fix(verify): preserve Linux descendant records with multiline names

* fix(verify): load the stat parser without changing stderr

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:21 -05:00
ShuaixinHuangandShuaixinHuang 40f9269284 fix(ci): use the test deadline for conformance fixture commands (#12022)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:07 -05:00
ShuaixinHuangandShuaixinHuang f4efc293dd fix(ci): retry GitHub file reads after gateway timeouts (#11987)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:02 -05:00
ShuaixinHuangandShuaixinHuang e98a767428 fix(desktop): exclude configured APT status from repository sources (#11932)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:56:54 -05:00
ShuaixinHuangandShuaixinHuang e39a53d5cd fix(windows): preserve opaque ANSI shortcut path identity (#11923)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:56:47 -05:00
ShuaixinHuangandShuaixinHuang 18c6b4490c fix(desktop): retain all matching APT primary-key blocks (#11944)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:56:39 -05:00
ShuaixinHuangandShuaixinHuang c4f9ead498 fix(verify): honor an explicit conformance source root (#11943)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:56:35 -05:00
David Muñoz ReyandDayan Kijege 53977802b3 test(process): count zombie descendants as stopped in cleanup checks (#12091)
Where PID 1 does not reap orphans promptly, a killed descendant stays a zombie for a while. Signal 0 still reaches a zombie, and a raw process table still lists it, so four boundary tests decided a stopped process was alive although cleanup had worked.

The stop assertions in artifactVerifierCleanupOwner and desktopBuildOwnedCommand now use processHasStopped. The run-token sweep in ownedCommand reads the product's liveProcesses view, which drops zombie rows. The testing guide says to assert a stop this way and not with signal 0.

Ported onto current main from morluto/rea#11837. The helper and the first eight cases landed in morluto/rea#12034, so this keeps the four that remained.

Co-authored-by: Dayan Kijege <dayanusa7@gmail.com>
2026-11-18 14:48:37 -05:00
ShuaixinHuang 75482a9ef9 fix(ota): merge partition info without discarding integrity claims (#11836) 2026-11-18 14:47:46 -05:00
ShuaixinHuang 004c43e32a fix(maven): preserve qualified property keys in metadata (#11860)
fix(maven): preserve qualified property keys
2026-11-18 14:47:42 -05:00
mengzhe ganandmorluto 82e16b4dda fix(setup): write the recommended tool call timeout into dsh registrations (#4043)
* fix(setup): write the recommended tool call timeout into dsh registrations

rea setup --client dsh wrote registrations without toolCallTimeoutMs, so
DeepSeek Harness applied its 60-second default while a native provider
startup alone can exceed it. Setup now derives the deadline from the same
provider allowance plus operation headroom used for Kimi and Codex,
preserves a positive caller-selected value, and doctor reports a
registration without a usable timeout as stale.

ProviderRequestBudgetResolver declares an optional budgetSettings read
set, so the fail-closed budget gate rejects unresolved Cordis expressions
only for settings the derivation may read plus the timeout inputs; an
unrelated expression such as GHIDRA_INSTALL_DIR still refreshes, and an
expression in REA_IDA_MCP_CONFIG fails closed.

* test(setup): record the dsh tool call deadline in the NUL repair fixture

The NUL refusal scenario rewrites a valid dsh registration and expects
doctor to report it healthy. That fixture omitted toolCallTimeoutMs,
which doctor now reports stale, so the repaired registration records the
deadline a current dsh registration carries.

* test(setup): separate dsh timeout repair coverage

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 14:31:34 -05:00
b236bcfe34 fix(browser): match the win32 environment snapshot spelling for SystemRoot (#8387)
Browser scenario launches forward a caller-selected environment through
snapshotEnvironment, which uppercases every name on win32. The launch
allowlist read the mixed-case "SystemRoot" spelling, so the lookup was
always undefined on Windows and the launched browser never received the
variable the allowlist intends to forward; the effective launch
environment was only HOME/LANG/PATH/TEMP/TMP.

Node's Windows spawn path re-adds a small set of system variables from
the parent environment, which has masked the missing entry so far, but
that behavior is outside REA's contract. The Electron active-provider
allowlist already reads "SYSTEMROOT" (uppercase) for the same snapshot,
so match that spelling here and keep the launched browser environment
dependent only on REA's own allowlist.

Co-authored-by: Vinicius Henrique Menezes Moreira <29902685+SwintexD@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 13:36:29 -05:00
David Muñoz ReyandAmmarJamil23 0b95fa7d69 fix(pe): admit Authenticode nesting depth of signed Windows binaries (#12082)
* fix(pe): admit Authenticode nesting depth of signed Windows binaries

inspect_pe_certificates refused genuine Authenticode signatures with "ASN.1 nesting exceeds 32 levels". Windows dual signing embeds whole SignedData values in unsigned attributes: a nested signature (1.3.6.1.4.1.311.2.4.1) holding an RFC 3161 timestamp (1.3.6.1.4.1.311.3.3.1). Each embedding adds eight levels, so signed system binaries pass the shared reader's default of 32.

The PE certificate reader now gives the shared ASN.1 reader its own depth allowance of 64. The node allowance is unchanged, and a payload past the depth allowance is still refused as an exhausted fixed allowance.

Ported onto current main from morluto/rea#7160. The fixture gains signed attributes through its fields argument, and the provider's allowance test moves to the new limit.

* test(pe): pin the Authenticode depth allowance at its boundary

The dual-signed fixture has to be deeper than the shared reader's default, or it would pass without the PE depth allowance. An independent DER walk now asserts its depth, and a boundary case admits nesting at the allowance and refuses one level more as an exhausted allowance.

The certificate guide states the depth allowance next to the value allowance.

---------

Co-authored-by: AmmarJamil23 <ammarjamil7000@gmail.com>
2026-11-18 13:29:11 -05:00